[feat #91] 알림 목록/읽기 API #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
Test Results 23 files 23 suites 13s ⏱️ Results for commit d3f666b. ♻️ This comment has been updated with latest results. |
hyun2371
reviewed
Sep 1, 2024
src/test/java/com/dnd/gongmuin/notification/service/NotificationServiceTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/dnd/gongmuin/answer/service/AnswerService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/dnd/gongmuin/notification/controller/NotificationController.java
Outdated
Show resolved
Hide resolved
|
|
||
| private BooleanExpression targetTypeEq(String type) { | ||
| if (type == null || type.isEmpty() || "전체".equals(type)) { | ||
| return null; |
There was a problem hiding this comment.
알림을 타입별로 조회했을 때 어떠한 이점이 있는지, 알림 필터링 기능이 있는 타 서비스는 어떤게 있는지 궁금합니다!
There was a problem hiding this comment.
간편성..? 정도가 있다고 생각됩니다. 타 서비스에는 알림 필터링 기능들이 대부분 없지만 채팅과 게시글(답글, 채택) 관련 알림들이 한 곳에 모여 있는게 복잡해보이곘다 생각이 들어서요!
Code Coverage
|
hyun2371
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
📑 작업 상세 내용
💫 작업 요약
🔍 중점적으로 리뷰 할 부분